953339 - For movemail account wizard shows fields it shouldn't in done page and is missing some too

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Ian Neal]

Steps to reproduce
1/ Start to create a movemail account using the account wizard.
2/ Fill in details on all the pages and get to done page.

Expected Result
1/ All information that has been filled in is shown and fields not asked for are hidden.

Actual Result
1/ It shows a blank for incoming server type, port and news server name.
2/ It shows a blank for outgoing server name even though something was filled in.

Comment 1

[:aceman]

Attachment: 953339.patch

Is this better? In TB the wizard only offers movemail and news accounts so I only tested those. I fixed some exceptions and warnings on undefined members.
The protocolinfo stuff got broken in bug 861767. Am I right, that the object is not a real nsIMsgIncomingServer object?

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8365347 [details] [diff] [review]
953339.patch

Review of attachment 8365347 [details] [diff] [review]:
-----------------------------------------------------------------

WFM

::: mailnews/base/prefs/content/AccountWizard.js
@@ +259,5 @@
>      }
>      setPageData(pageData, "accounttype", "otheraccount", false);
>    }
> +
> +  setPageData(pageData, "login", "username", server.username ? server.username : "");

if you want to write it shorter you could use 
 setPageData(pageData, "login", "username", server.username || "");

... here and the other places

Comment 3

[Ian Neal]

Comment on attachment 8365347 [details] [diff] [review]
953339.patch

r=me with changes previously suggested

Comment 4

[:aceman]

Attachment: patch v2

Thanks, updated.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/6e585f3aa138