Closed
Bug 953339
Opened 11 years ago
Closed 10 years ago
For movemail account wizard shows fields it shouldn't in done page and is missing some too
Categories
(MailNews Core :: Account Manager, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 30.0
People
(Reporter: iannbugzilla, Assigned: aceman)
Details
Attachments
(1 file, 1 obsolete file)
8.13 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce 1/ Start to create a movemail account using the account wizard. 2/ Fill in details on all the pages and get to done page. Expected Result 1/ All information that has been filled in is shown and fields not asked for are hidden. Actual Result 1/ It shows a blank for incoming server type, port and news server name. 2/ It shows a blank for outgoing server name even though something was filled in.
Is this better? In TB the wizard only offers movemail and news accounts so I only tested those. I fixed some exceptions and warnings on undefined members. The protocolinfo stuff got broken in bug 861767. Am I right, that the object is not a real nsIMsgIncomingServer object?
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #8365347 -
Flags: review?(mkmelin+mozilla)
Attachment #8365347 -
Flags: review?(iann_bugzilla)
Comment 2•10 years ago
|
||
Comment on attachment 8365347 [details] [diff] [review] 953339.patch Review of attachment 8365347 [details] [diff] [review]: ----------------------------------------------------------------- WFM ::: mailnews/base/prefs/content/AccountWizard.js @@ +259,5 @@ > } > setPageData(pageData, "accounttype", "otheraccount", false); > } > + > + setPageData(pageData, "login", "username", server.username ? server.username : ""); if you want to write it shorter you could use setPageData(pageData, "login", "username", server.username || ""); ... here and the other places
Attachment #8365347 -
Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8365347 [details] [diff] [review] 953339.patch r=me with changes previously suggested
Attachment #8365347 -
Flags: review?(iann_bugzilla) → review+
Thanks, updated.
Attachment #8365347 -
Attachment is obsolete: true
Attachment #8379873 -
Flags: review+
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/6e585f3aa138
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
You need to log in
before you can comment on or make changes to this bug.
Description
•